-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Tachometer GitHub Action #142
Comments
Can you share any additional details about what makes integration complicated today? |
The way we currently do perf regression testing for the lit-element and lit-html repos is by running tachometer piggy-backed on Travis, alongside the unit tests. Tachometer itself then knows how to post its results back using the GitHub API, using credentials for a GitHub "App" so that it shows up as its own result "check" (e.g. https://github.com/Polymer/lit-element/pull/987/checks). Relevant code: https://github.com/Polymer/lit-element/blob/master/travis-bench.sh So, switching to a GitHub Action would be much simpler, since we shouldn't need any of this API integration, credential passing, or Travis-piggybacking. Open question how we display the result table, though. For a GitHub Check, the API lets you post markdown that will show up in the Checks tab. Maybe an Action can also be a check? Maybe it can post a comment? I'm slightly fuzzy on the interaction between Actions and Checks here. |
@cdata (mentioning you since you assigned yourself to this) FWIW I built a GitHub action to report tachometer results as a comment in a PR: andrewiggins/tachometer-reporter-action. I found that trying to use the checks API and actions together is not as valuable since an action job shows up as a check on a PR so the additional check felt redundant. Anyway, happy to discuss ways to make this more helpful to the community if you are interested |
FYI - just added support for multiple measurements per benchmarks in my reporter action, one thing that was notably missing before. |
We have a somewhat complicated integration that works with Travis or any other CI system. I think that now that GitHub Actions exist, we could have a much simpler workflow instead.
The text was updated successfully, but these errors were encountered: