-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update learn more link in Sign in with Google toggle. #9772
base: develop
Are you sure you want to change the base?
Conversation
Note, as of creating this PR the URL links to 404 but I assume the documentation is yet to be published. |
Build files for 9bb67f2 are ready:
|
Size Change: +20 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @benbowler – this will need updating as this issue was somewhat incompletely defined. I've gone ahead and updated the AC + IB to be more clear for consistency regarding our approach to these kinds of links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sending back for a quick follow-up.
…d use in OneTapToggle link.
Hey @aaemnnosttv, I had to update the |
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist