Skip to content

Commit

Permalink
Address CR feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
kuasha420 committed Dec 16, 2022
1 parent d6d889b commit 9197ff7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
8 changes: 4 additions & 4 deletions includes/Core/REST_API/Data_Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function __isset( $name ) {
*/
// phpcs:ignore Squiz.Commenting.InlineComment.WrongStyle,Squiz.PHP.CommentedOutCode.Found
#[\ReturnTypeWillChange]
public function offsetExists( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment.WrongStyle
public function offsetExists( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment
return array_key_exists( $key, $this->data );
}

Expand All @@ -136,7 +136,7 @@ public function offsetExists( $key ) { // phpcs:ignore Squiz.Commenting.Function
*/
// phpcs:ignore Squiz.Commenting.InlineComment.WrongStyle,Squiz.PHP.CommentedOutCode.Found
#[\ReturnTypeWillChange]
public function offsetGet( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment.WrongStyle
public function offsetGet( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment
if ( $this->offsetExists( $key ) ) {
return $this->data[ $key ];
}
Expand All @@ -152,7 +152,7 @@ public function offsetGet( $key ) { // phpcs:ignore Squiz.Commenting.FunctionCom
*/
// phpcs:ignore Squiz.Commenting.InlineComment.WrongStyle,Squiz.PHP.CommentedOutCode.Found
#[\ReturnTypeWillChange]
public function offsetSet( $key, $value ) { // phpcs:ignore Squiz.Commenting.FunctionComment.WrongStyle
public function offsetSet( $key, $value ) { // phpcs:ignore Squiz.Commenting.FunctionComment
// Data is immutable.
}

Expand All @@ -163,7 +163,7 @@ public function offsetSet( $key, $value ) { // phpcs:ignore Squiz.Commenting.Fun
*/
// phpcs:ignore Squiz.Commenting.InlineComment.WrongStyle,Squiz.PHP.CommentedOutCode.Found
#[\ReturnTypeWillChange]
public function offsetUnset( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment.WrongStyle
public function offsetUnset( $key ) { // phpcs:ignore Squiz.Commenting.FunctionComment
// Data is immutable.
}
}
3 changes: 0 additions & 3 deletions tests/phpunit/integration/ContextTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ public function test_filter_input() {
$_GET['foo'] = true;

$this->assertTrue( $context->input()->filter( INPUT_GET, 'foo', FILTER_VALIDATE_BOOLEAN ) );

$_GET['dirty'] = '<script>dirt</script>';
$this->assertEquals( '&lt;script&gt;dirt&lt;/script&gt;', htmlspecialchars( $context->input()->filter( INPUT_GET, 'dirty' ) ) );
}

public function test_admin_url() {
Expand Down

0 comments on commit 9197ff7

Please sign in to comment.