Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of payload in header is incorrect - should be size of compressed payload, not uncompressed #60

Open
mharvey-jt opened this issue Jun 10, 2021 · 2 comments

Comments

@mharvey-jt
Copy link

Hi,

The size of the payload written to the Size header is incorrect. It should be the length of the compressed payload, not the sun of the sizes of the uncompressed payload files.
This makes the rpm2cpio program exit with a failure, as it does a comparison between the header value and that returned by librpm's ufdCopy() function.

@jarondl
Copy link
Collaborator

jarondl commented Jun 25, 2021

Are you sure? According to https://docs.fedoraproject.org/ro/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch-package-structure.html

The RPMTAG_SIZE tag holds the size of all the regular files in the payload

Doesn't the error actually mean that the cpio size is incorrect?

Also, is this the same as #61? Does it happen only with certain compression algos?

@mharvey-jt
Copy link
Author

Interesting, I hadn't found the spec, but rather come to that conclusion by comparison with distro rpms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants