Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are installed #422

Open
dvzrv opened this issue Dec 15, 2022 · 1 comment
Open

Tests are installed #422

dvzrv opened this issue Dec 15, 2022 · 1 comment

Comments

@dvzrv
Copy link

dvzrv commented Dec 15, 2022

Hi! I package this project for Arch Linux.

I noticed, that all test files are installed when installing this package. Although the test files should be part of an sdist or source tarball, they should not be installed to the target system, as tests should be run beforehand.

Moving the various *_test.py and testutils.py files from the fire/ directory to a dedicated tests/ directory would help you to ignore them for installation.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 15, 2022
Switch to PEP517.
Remove test files: google/python-fire#422

git-svn-id: file:///srv/repos/svn-community/svn@1359238 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Dec 15, 2022
Switch to PEP517.
Remove test files: google/python-fire#422

git-svn-id: file:///srv/repos/svn-community/svn@1359238 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@dbieber
Copy link
Member

dbieber commented Dec 20, 2022

Thanks for the note. The reason the tests files live alongside the source files is to conform to Google's internal conventions.
I'll use this issue to look into adding a transform such that we can keep the current structure internally but use your suggested structure here on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants