Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.1 looks broken: preview eventually erroring with 404 #418

Open
tbroyer opened this issue Oct 14, 2024 · 3 comments
Open

Release 0.19.1 looks broken: preview eventually erroring with 404 #418

tbroyer opened this issue Oct 14, 2024 · 3 comments

Comments

@tbroyer
Copy link

tbroyer commented Oct 14, 2024

I wanted to update my blog's dependencies and noticed my playground elements' preview no longer working. Rolling back to 0.18.1 made it functional again.

Reproduced in the demo at https://google.github.io/playground-elements/ with Firefox and Chrome.

Maybe latest on NPM should be rolled back to 0.18.1 so people aren't being upgraded to 0.19.1 by tools such as Dependabot/Renotave or npm-check-updates?

@tbroyer
Copy link
Author

tbroyer commented Oct 16, 2024

Tracked to being a side effect of #398; I left a comment there (h/t @oscarmarina)

@justinfagnani
Copy link
Collaborator

So the issue is that internal/typescript.js needs to be be copied along with playground-typescript-worker.js? I think we could copy typescript.js to a less scary sounding name than internal/... and add it to the docs under bundling. Or we could figure out a way to not bundle typescript.js in dev, but bundle it for release.

0.19 would be a breaking change over 0.18, so I don't think we need to roll anything back. Right now I'd say we have missing docs.

@tbroyer
Copy link
Author

tbroyer commented Oct 16, 2024

Would be great if it was bundled into the worker script for release, as it would then continue to "just work" with @web/rollup-plugin-import-meta-assets (I can't tell for Webpack, haven't used it for at least half a decade). With this plugin, Rollup currently copies and renames the worker script, but as it doesn't process it it doesn't copy the typescript.js file.

But if you know of other ways to make it seamless (maybe just document the copy plugin for rollup then?) then yes I agree it's mainly a documentation issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants