diff --git a/pw_log_tokenized/base64_over_hdlc.cc b/pw_log_tokenized/base64_over_hdlc.cc index 1f8942aecf..b14d18b2c2 100644 --- a/pw_log_tokenized/base64_over_hdlc.cc +++ b/pw_log_tokenized/base64_over_hdlc.cc @@ -41,8 +41,8 @@ extern "C" void pw_log_tokenized_HandleLog( const pw::InlineBasicString base64_string = PrefixedBase64Encode(log_buffer, size_bytes); - // HDLC-encode the Base64 string via a SysIoWriter. - // TODO: https://pwbug.dev/357136096 - Maybe don't ignore the error? + // HDLC-encode the Base64 string via a SysIoWriter. Ignore errors since we + // cannot take any action anyway. hdlc::WriteUIFrame( kBase64LogHdlcAddress, as_bytes(span(base64_string)), writer) .IgnoreError(); diff --git a/third_party/freertos/pw_assert_stack_overflow_hook.cc b/third_party/freertos/pw_assert_stack_overflow_hook.cc index f5e51b5e42..3f5ad3447e 100644 --- a/third_party/freertos/pw_assert_stack_overflow_hook.cc +++ b/third_party/freertos/pw_assert_stack_overflow_hook.cc @@ -28,7 +28,6 @@ extern "C" void vApplicationStackOverflowHook(TaskHandle_t, char* pcTaskName) { // Copy the task name to a buffer in case it is corrupted. static char temp_thread_name_buffer[configMAX_TASK_NAME_LEN]; - // TODO: https://pwbug.dev/357139112 - Review the IgnoreError call. pw::string::Copy(pcTaskName, temp_thread_name_buffer).IgnoreError(); PW_CRASH("Stack overflow for task %s", temp_thread_name_buffer); }