Ensure that all heap allocations use the marl::Allocator #131
Comments
ben-clayton
added a commit
to ben-clayton/marl
that referenced
this issue
Jun 5, 2020
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: google#131
ben-clayton
added a commit
to ben-clayton/marl
that referenced
this issue
Jun 5, 2020
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: google#131
ben-clayton
added a commit
to ben-clayton/marl
that referenced
this issue
Jun 5, 2020
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: google#131
ben-clayton
added a commit
to ben-clayton/marl
that referenced
this issue
Jun 5, 2020
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: google#131
ben-clayton
added a commit
that referenced
this issue
Jun 5, 2020
`StlAllocator` uses a `marl::Allocator` for performing the allocations, avoiding untracked heap allocations. Issue: #131
|
RE shared_ptr; this may be useful: https://github.com/google/iree/blob/main/iree/base/ref_ptr.h (thread-safe intrusive pointer with support for type-specific custom deleters to make pooling easier) |
|
This pull request also replaces std::function with std::packaged_task. std::packaged_task can take an allocator which will help with some of this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
marl::Allocatoris the user-implementable interface that should be used for all marl heap allocations.At the time of writing there are many places where we use
stdcontainers with the default allocator, which is clearly bypassing themarl::Allocator.We should ensure that all allocations go through the provided
marl::Allocator.The text was updated successfully, but these errors were encountered: