Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate if InPlacePodVerticalScaling feature gate is enabled #63

Closed
mikouaj opened this issue Sep 16, 2024 · 0 comments · Fixed by #72
Closed

feat: validate if InPlacePodVerticalScaling feature gate is enabled #63

mikouaj opened this issue Sep 16, 2024 · 0 comments · Fixed by #72
Assignees
Labels
enhancement New feature or request

Comments

@mikouaj
Copy link
Member

mikouaj commented Sep 16, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction
    to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
    not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

The InPlacePodVerticalScaling feature gate is crucial for the Kube Startup CPU Boost operator. Without this feature gate enabled, the operator will increase POD resources without the possibility to revert them back when needed. Therefore, the operator should validate if the InPlacePodVerticalScaling is enabled.

NOTE: this is interim solution until InPlacePodVerticalScaling graduates to beta.
There is no perfect way to programmatically validate if a feature gate is enabled cluster wide. The most straightforward but not perfect solution is to use /metrics/ API that eventually consistent.

References

@mikouaj mikouaj self-assigned this Oct 11, 2024
@mikouaj mikouaj added the enhancement New feature or request label Oct 11, 2024
@mikouaj mikouaj linked a pull request Oct 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant