Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fail on error mode #28

Open
realityforge opened this issue Mar 27, 2019 · 1 comment
Open

Add a fail on error mode #28

realityforge opened this issue Mar 27, 2019 · 1 comment

Comments

@realityforge
Copy link
Contributor

Currently Elemental2 builds can produce warnings that do not halt the build. As a result it is possible for to introduce more problems in code generated from this tool without realizing it. For example a a recent commit introduced the error

Mar 26, 2019 8:03:44 PM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: external/com_google_closure_compiler/externs/browser/url.js:162: WARNING - Bad type annotation. Unknown type MediaSource
 * @param {!File|!Blob|!MediaSource|!MediaStream} obj

A possible solution is to update the generator tool so that it will fail if warnings that are not part of a known problems list will cause the build to fail. A possibly simpler alternative is to just introduce a fail on warning flag and fix the problems in Elemental2.

@jDramaix
Copy link
Member

jDramaix commented Jun 7, 2019

I'll take a look, initially, jsinterop-generator failed when a type was unknown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants