Inconsistency between indent level in AOSP and non-aosp

[blacksails]

I am not entirely sure wether this is the intended behavior, so here is an issue. The the continuation of the long string doesn't indent with 8 spaces from the previous line which I would expect in AOSP.

Test.java

public class Test {
    String s = "asdfasdfasdfasdf asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

❯ java -jar ~/Downloads/google-java-format-1.24.0-all-deps.jar Test.java
public class Test {
  String s =
      "asdfasdfasdfasdf"
          + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

❯ java -jar ~/Downloads/google-java-format-1.24.0-all-deps.jar --aosp Test.java
public class Test {
    String s =
            "asdfasdfasdfasdf"
                + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

I would expect the following output using AOSP style

public class Test {
    String s =
            "asdfasdfasdfasdf"
                    + " asdfasdfasdfasdfasdfasdffasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasd";
}

I raised this issue in the spotless repo because I figured that spotless not indenting the same way as GJF would be a spotless bug.

If this is the intended behavior, please let me know, so that I can reraise the issue at spotless.

[blacksails]

Spotless issue for reference: diffplug/spotless#2338

[cushon]

Thanks for the report. The wrapping of long string literals is handled as a separate pass (--skip-reflowing-long-strings), and I think it's making non-AOSP assumptions instead of passing in the configuration.

I haven't double-checked if this is the exact culprit, but this comment looks suspicious:

google-java-format/core/src/main/java/com/google/googlejavaformat/java/StringWrapper.java

Line 414 in 20c526c

width -= 6; // subsequent lines have a four-space continuation indent and a `+ `