Windows TPM Base Services (TBS) - Implement Tbsi_Get_OwnerAuth #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfenner
reviewed
Jul 1, 2022
| @@ -250,3 +264,26 @@ func (context Context) GetTCGLog(logBuffer []byte) (uint32, error) { | |||
| ) | |||
| return logBufferLen, getError(result) | |||
| } | |||
|
|
|||
| // GetOwnerAuth Retrieves the owner authorization of the TPM if the information is available in the local registry. | |||
| // If ownerAuthBuffer is nil, the actual size of the TPM ownerAuth is returned. | |||
There was a problem hiding this comment.
Why not allocate the slice from within this function and return ([]byte, error)?
| t.Log("Skipping retrieval of Storage authorization; Delegation blob not available in the registry.") | ||
| t.SkipNow() | ||
| } | ||
| } |
There was a problem hiding this comment.
Might make sense to try using the auth value to make sure it came through correctly (i.e., doesn't need base64 decoded or something)
| defer ctx.Close() | ||
|
|
||
| authBufferLength, err := ctx.GetOwnerAuth(Storage20Authorization, nil) | ||
| if err == ErrOwnerauthNotFound || err == ErrInternalError { |
There was a problem hiding this comment.
Are you sure that this check will only skip the test if the TBS call failed due to lack of admin rights?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation and tests for
TBS.hfunction Tbsi_Get_OwnerAuth.Fixes #275