Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the mocking of LayerNormalization in tests #140

Open
ondrasej opened this issue Jul 18, 2024 · 0 comments
Open

Remove the mocking of LayerNormalization in tests #140

ondrasej opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ondrasej
Copy link
Collaborator

As discussed in the review of #132, we're patching tf_keras.layers.LayerNormalization with itself in some of our tests, e.g. in gematria/granite/python/gnn_model_base_test.py. We should investigate whether this mocking is still needed, and if not, remove it.

@ondrasej ondrasej added the enhancement New feature or request label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants