Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR CIs do not fail if the benchmark doesn't exist #2037

Open
DonggeLiu opened this issue Aug 22, 2024 · 0 comments
Open

PR CIs do not fail if the benchmark doesn't exist #2037

DonggeLiu opened this issue Aug 22, 2024 · 0 comments

Comments

@DonggeLiu
Copy link
Contributor

Discovered by @addisoncrump: #2032 (comment)

A more informative alternative is to let the CI fail and report 'the benchmark does not exist' to avoid misleading the user and inform us to remove/update CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DonggeLiu