-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench: Version 2.000;gftools[0.9.33] added #6917
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
* Workbench Version 2.000 taken from the upstream repo https://github.com/jenskutilek/homecomputer-fonts at commit jenskutilek/homecomputer-fonts@9a28003.
Updated Workbench: Version 2.000 addedf45a382: [gftools-packager] Workbench: Version 2.000 added
|
7e2172c
to
f45a382
Compare
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[16] Workbench[BLED,SCAN].ttf🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
The link will exist when #6919 is merged. We should remember to counter-check the link once in prod.
Due to the historical origin of the fonts, it was agreed to accept these fails.
Given the font only includes custom axes, it is accepted for them to include custom-named instances. After Kablammo's case, this was confirmed for the homecomputer fonts. I need to include this in the GF-Guide
Bug reported in googlefonts/axisregistry#99 (comment)
The SCAN and BLED axes were already merged in the googlefonts/axisregistry repo and will be brought with an upcoming git subtree pull. Please only merge this PR once I create that git subtree pull. I'll inform you about it
Jens Kutílek bio info was added in #6935 |
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[16] Workbench[BLED,SCAN].ttf🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints] 🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
@vv-monsalve the "regular" instance correspond to the "close" location but is called "regular" in the FVAR table |
After discussing the axes with @vv-monsalve, we decided to merge the PR so see how they render in sandbox but she would make a new PR where "Close" is elided in the STAT table for better cross-platform naming consistency. |
2690e14: [gftools-packager] Workbench: Version 2.000;gftools[0.9.33] added