-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wavefont #4631
Comments
@RosaWagner is that better to create a separate issue for new axis registration? It seems that ALGN axis must be there, it seems to be useful to have for multiple purposes. Can you please forward to existing issues that can act as an example? |
hi @dy, sorry for the delayed answer, I was in a long holidays. Good example of submission would be: googlefonts/axisregistry#38 and googlefonts/axisregistry#42 |
@RosaWagner I got stuck with transitioning, it turned out to be more complicated than just reordering folders, updating the license and copy-pasting binaries, it is in fact imposition of completely google methodology of creating fonts up to smallest details. I'm sorry, I'm fine with the font not being published to Google Fonts. Giving up. |
I'm sorry to hear that Dmitry. Will you please let us know where you are stuck so that we understand how to help you? |
@dy thanks for attempting. This is very useful feedback for us. We are willing to take care of everything for your project and just submit a PR to you, and so your involvement is limited to discussion and review/approval only. |
Ah, the key thing we need is your confirmation to change the license from the cc license in https://github.com/a-vis/wavefont/blob/master/license.md today to the sil open font license :) |
@davelab6 sure, I'm fine with changing the license. |
@chrissimpkins mostly docs - they are super-detailed and time-consuming. I'd suggest a list of example font repos or cases of "googlifying" would help more, rather than longreads. |
We provide a template repo in this org and fontbakery to lint your project so you don't need to read everything if you don't want to. Definitely good feedback to know there should be a "quick start, tldr" page at the front of Googlefonts.github.io/gf-guide :) We have the libre barcode fonts project that's similar, maybe we don't need to make the Core, it even Kernel, as they do; or maybe we can do something like what Adobe Blank/NotDef do and have 64k character support :) |
Thanks! Stubbing everything with blanks would be preferrable, because wavefont falls back to adobe blank anyways via css. I don't know how to do that compact though as it's done in https://github.com/adobe-fonts/adobe-blank-vf (1kb only) |
@dy I can look it up next week. |
@dy I need your help to understand how the font is build, can we set up a call? |
@RosaWagner sure, you can contact or hangout to [email protected] |
@RosaWagner I've updated folders structure, you can see UFOs stored under |
@davelab6 it seems all of the tasks in a list are done, thanks to @RosaWagner's and @simoncozens effort. |
note to self: this family will need a custom sample text for the specimen page to render interesting shapes. I don't think the usual sentence will make sense here. @dy you can write down here several strings of characters we could use :) |
Sure. This is nice one.
|
Thank you @RosaWagner, refactored axis to YALN. I hope it won't be changed after review. |
@dy YALN was approved by the GF engineering lead for axis registration and @RosaWagner will pick this up soon |
Font Project Git Repo URL:
Related to #4630
https://github.com/a-vis/wavefont/
Super short description of the Font Family:
Similar to barcode, redacted and flow fonts, wavefont is a 'non text' font that uses variable fonts tech to provide a typo-graphic utility, in the long history of border/dingbat fonts.
Dima Iv (who has the enviable github username @dy :) has agreed to make the project meet our requirements soon, and I've asked him to update this issue when he is ready for us to review his repo and PR any other changes that we need. I've filled out the check-list below to roughly match that intent and the current state.
Requirements:
I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):
The text was updated successfully, but these errors were encountered: