Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wavefont #4631

Closed
9 tasks done
davelab6 opened this issue May 11, 2022 · 20 comments · Fixed by #6185
Closed
9 tasks done

Add Wavefont #4631

davelab6 opened this issue May 11, 2022 · 20 comments · Fixed by #6185
Assignees
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Custom axes Contains unregistered MS axis (even if registered by GF)
Milestone

Comments

@davelab6
Copy link
Member

davelab6 commented May 11, 2022

Font Project Git Repo URL:

Related to #4630

https://github.com/a-vis/wavefont/

Super short description of the Font Family:

Similar to barcode, redacted and flow fonts, wavefont is a 'non text' font that uses variable fonts tech to provide a typo-graphic utility, in the long history of border/dingbat fonts.

Dima Iv (who has the enviable github username @dy :) has agreed to make the project meet our requirements soon, and I've asked him to update this issue when he is ready for us to review his repo and PR any other changes that we need. I've filled out the check-list below to roughly match that intent and the current state.

Requirements:

I understand that Google Fonts will publish only fonts that matches its requirements, and I can confirm the project meets them (by ticking the cases, or putting x between the square brackets in text mode):

  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I read, agree and comply with the full contributing requirements
  • I am the author of the font or the author agreed to this submission
  • I will maintain the repository
@davelab6 davelab6 added I New Font II Accepted Non-commissioned projects that are accepted for onboarding labels May 11, 2022
@davelab6 davelab6 added this to the 2022 Q3 milestone May 11, 2022
@RosaWagner RosaWagner added the -- Upstream is working on it Designer is making changes in the upstream repo label May 11, 2022
@dy dy mentioned this issue May 13, 2022
12 tasks
@RosaWagner RosaWagner added the -- Requires Axis Registration Variable axes are not yet registered label Jul 20, 2022
@dy
Copy link

dy commented Jul 31, 2022

@RosaWagner is that better to create a separate issue for new axis registration? It seems that ALGN axis must be there, it seems to be useful to have for multiple purposes. Can you please forward to existing issues that can act as an example?

@RosaWagner
Copy link
Contributor

hi @dy, sorry for the delayed answer, I was in a long holidays.
For the axis registration it happens here: https://github.com/googlefonts/axisregistry

Good example of submission would be: googlefonts/axisregistry#38 and googlefonts/axisregistry#42

@RosaWagner RosaWagner self-assigned this Sep 15, 2022
@RosaWagner RosaWagner modified the milestones: 2022 Q3, 2022 Q4 Sep 15, 2022
@RosaWagner RosaWagner mentioned this issue Sep 30, 2022
9 tasks
@RosaWagner RosaWagner added the -- missing sources Need to ask designer to upload sources in upstream repo label Sep 30, 2022
@dy
Copy link

dy commented Oct 11, 2022

@RosaWagner I got stuck with transitioning, it turned out to be more complicated than just reordering folders, updating the license and copy-pasting binaries, it is in fact imposition of completely google methodology of creating fonts up to smallest details.
Spent 3 days installing tools, reading the docs and wrapping my mind how to reorganize the font and realized that I'm not even at 5% of required work. The entry barrier is too high, if someone is not fulltime font developer, it is just ridiculous waste.

I'm sorry, I'm fine with the font not being published to Google Fonts. Giving up.

@chrissimpkins
Copy link
Collaborator

I'm sorry to hear that Dmitry. Will you please let us know where you are stuck so that we understand how to help you?

@davelab6
Copy link
Member Author

@dy thanks for attempting. This is very useful feedback for us. We are willing to take care of everything for your project and just submit a PR to you, and so your involvement is limited to discussion and review/approval only.

@davelab6
Copy link
Member Author

Ah, the key thing we need is your confirmation to change the license from the cc license in https://github.com/a-vis/wavefont/blob/master/license.md today to the sil open font license :)

@dy
Copy link

dy commented Oct 14, 2022

@davelab6 sure, I'm fine with changing the license.
A bit of problem here comes with generating 0-56 alias values for a-zA-Z latin range, also stubbing rest of Latin Core. If you can help I'd greatly appreciate.
Also to note - that font is generated from template via plopfile, so likely there would be a separate build step in build.sh.

@dy
Copy link

dy commented Oct 14, 2022

@chrissimpkins mostly docs - they are super-detailed and time-consuming. I'd suggest a list of example font repos or cases of "googlifying" would help more, rather than longreads.

@davelab6
Copy link
Member Author

We provide a template repo in this org and fontbakery to lint your project so you don't need to read everything if you don't want to. Definitely good feedback to know there should be a "quick start, tldr" page at the front of Googlefonts.github.io/gf-guide :)

We have the libre barcode fonts project that's similar, maybe we don't need to make the Core, it even Kernel, as they do; or maybe we can do something like what Adobe Blank/NotDef do and have 64k character support :)

@dy
Copy link

dy commented Oct 15, 2022

Thanks! Stubbing everything with blanks would be preferrable, because wavefont falls back to adobe blank anyways via css. I don't know how to do that compact though as it's done in https://github.com/adobe-fonts/adobe-blank-vf (1kb only)

@RosaWagner
Copy link
Contributor

@dy I can look it up next week.

@RosaWagner
Copy link
Contributor

@dy I need your help to understand how the font is build, can we set up a call?

@dy
Copy link

dy commented Oct 27, 2022

@RosaWagner sure, you can contact or hangout to [email protected]

@RosaWagner RosaWagner removed the -- missing sources Need to ask designer to upload sources in upstream repo label Oct 28, 2022
@dy
Copy link

dy commented Nov 2, 2022

@RosaWagner I've updated folders structure, you can see UFOs stored under source/wavefont100 folder.
I've added short description for gftools in https://github.com/dy/wavefont#building

@dy
Copy link

dy commented Dec 7, 2022

@davelab6 it seems all of the tasks in a list are done, thanks to @RosaWagner's and @simoncozens effort.
Please let know if any other changes are necessary.

@RosaWagner
Copy link
Contributor

note to self: this family will need a custom sample text for the specimen page to render interesting shapes. I don't think the usual sentence will make sense here. @dy you can write down here several strings of characters we could use :)

@dy
Copy link

dy commented Dec 9, 2022

Sure. This is nice one.

āĂ㥹ĆćĈċĊĉċčīıēģĹĶIJĺķĺĺijĽijĶĵĦČģĹĪĞĠĝġđČĐĤĨijħģĚģĢıĞĢİķīİijķĴIJĪĬģęĬķĦĒěěėďĒĚĪĢēČċěĩĘđēĞĝĚČčĖħĨĝġĈĉċĊĉċ蹥ăĂāāā

@RosaWagner RosaWagner removed this from the 2022 Q4 milestone Dec 14, 2022
@RosaWagner RosaWagner added this to the 2023 Q1 milestone Dec 14, 2022
@RosaWagner RosaWagner linked a pull request Dec 16, 2022 that will close this issue
@RosaWagner RosaWagner added II Custom axes Contains unregistered MS axis (even if registered by GF) and removed -- Upstream is working on it Designer is making changes in the upstream repo -- Requires Axis Registration Variable axes are not yet registered labels Dec 16, 2022
@RosaWagner
Copy link
Contributor

RosaWagner commented Mar 1, 2023

Hi @dy, let me know when the font has the YALN axis. #5721 was not reviewed while I was out, so will onboard Wavefont with all the axes at once.

cf googlefonts/axisregistry#106

@RosaWagner RosaWagner added the -- Requires Axis Registration Variable axes are not yet registered label Mar 1, 2023
@dy
Copy link

dy commented Mar 2, 2023

Thank you @RosaWagner, refactored axis to YALN. I hope it won't be changed after review.

@RosaWagner RosaWagner moved this from Todo to In Progress in Google Fonts Mar 7, 2023
@RosaWagner RosaWagner moved this from In Progress to PR Made in Google Fonts Mar 7, 2023
@RosaWagner RosaWagner moved this from PR Made to In Progress in Google Fonts Mar 9, 2023
@chrissimpkins chrissimpkins modified the milestones: 2023 Q1, 2023 Q2 Mar 24, 2023
@RosaWagner RosaWagner moved this from In Progress to PR Upstream in Google Fonts Apr 6, 2023
@RosaWagner RosaWagner moved this from PR Upstream to In Progress in Google Fonts Apr 13, 2023
@RosaWagner RosaWagner moved this from In Progress to PR Upstream in Google Fonts Apr 13, 2023
@RosaWagner RosaWagner moved this from PR Upstream to PR GF in Google Fonts Apr 13, 2023
@davelab6
Copy link
Member Author

davelab6 commented Jun 1, 2023

@dy YALN was approved by the GF engineering lead for axis registration and @RosaWagner will pick this up soon

@github-project-automation github-project-automation bot moved this from PR GF to In Dev / PR Merged in Google Fonts Jun 16, 2023
@RosaWagner RosaWagner modified the milestones: 2023 Q2, 2023 Q3 Jul 20, 2023
@RosaWagner RosaWagner removed the -- Requires Axis Registration Variable axes are not yet registered label Aug 1, 2023
@RosaWagner RosaWagner moved this from In Dev / PR Merged to Live in Google Fonts Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I New Font II Accepted Non-commissioned projects that are accepted for onboarding II Custom axes Contains unregistered MS axis (even if registered by GF)
Projects
Status: Live
Development

Successfully merging a pull request may close this issue.

4 participants