Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript tests #2462

Open
mgeisler opened this issue Nov 12, 2024 · 1 comment
Open

JavaScript tests #2462

mgeisler opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented Nov 12, 2024

Today, we don't have any tests for the JavaScript code found in

This has caused bugs in the past (the playgrounds disappeared at some point) and it makes it hard to upgrade mdbook (because we need to merge in changes to book.js manually).

It would be very helpful to have tests for these files. This should be something we can run on the command line in GitHub CI. I think we need something which

  • We can run on pre-rendered HTML files. I envision us running mdbook build (for each language).
  • A headless browser would then be needed to inspect the pages.
  • We would need a unit testing framework of some sort.
@michael-kerscher
Copy link
Collaborator

I created a first demo in that pull request to open a discussion before investing more in that direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants