Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper bazel support #378

Open
aaomidi opened this issue Aug 17, 2024 · 2 comments
Open

Proper bazel support #378

aaomidi opened this issue Aug 17, 2024 · 2 comments

Comments

@aaomidi
Copy link
Contributor

aaomidi commented Aug 17, 2024

The expected way expr is supposed to be imported in Go is: "cel.dev/expr" however, that links to https://github.com/google/cel-spec/blob/master/BUILD.bazel which is empty. This means any downstream users of this library that are using bazel get a broken experience.

I believe a go_library with name of "expr" needs to be defined in that build file.

@TristonianJones
Copy link
Collaborator

Hi @aaomidi I've been looking into some of the issues here and should have some fixes next week. Thanks for your patience!

@aaomidi
Copy link
Contributor Author

aaomidi commented Sep 27, 2024

Just in case anyone is interested in how I ended up working around this problem:

go_deps.gazelle_override(
    # Force Gazelle to wipe out the existing build files before regenerate them.
    build_file_generation = "clean",
    directives = [
        "gazelle:resolve proto go google/rpc/status.proto @org_golang_google_genproto_googleapis_rpc//status",
        "gazelle:resolve proto proto google/rpc/status.proto @googleapis//google/rpc:status_proto",
    ],
    path = "cel.dev/expr",
)

There's probably some negative side effects of this, but I haven't noticed any yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants