Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL spec is too protobuf centric? #217

Open
jpbetz opened this issue Nov 12, 2021 · 2 comments
Open

CEL spec is too protobuf centric? #217

jpbetz opened this issue Nov 12, 2021 · 2 comments

Comments

@jpbetz
Copy link

jpbetz commented Nov 12, 2021

We're using CEL in Kubernetes to integrate with OpenAPIv3 schema types. When providing developers with the CEL spec as reference, it's a bit difficult to explain how our "object with fields" type maps to CEL types, because the spec doesn't have a term for this type that is independent of protobuf. For now we say in our documentation that our "object with fields" type maps to "message", but this gets a bit confusing.

@TristonianJones
Copy link
Collaborator

Internally we've started shifting toward referring to protos as a specialized Struct, since it's a more generic term for an object with typed fields. Does this line up with your thinking as well?

@jpbetz
Copy link
Author

jpbetz commented Nov 17, 2021

Internally we've started shifting toward referring to protos as a specialized Struct, since it's a more generic term for an object with typed fields. Does this line up with your thinking as well?

Yes, "struct" would work well. It's probably my first choice. "object" is a bit of a problem for OpenAPI because it refers generically to all kinds of objects with fields (I.e "maps" and "structs").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@TristonianJones @jpbetz and others