Adds object-group support for IPv6 to Cisco generator #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhindes
requested changes
Mar 25, 2022
|
hi, sorry for the long-delay in response. Your commit looks good to me, there might be a minor merge conflict (the current change at the master branch is probably preferable to retain). Could you please let me know if you are still happy to proceed with this PR? |
|
Hi, just following up on this. |
|
hi abates, sorry for the trouble, but I think another internal change pushed right now is causing another merge conflict. If you could please re-sync once more time, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #295 by adding the "object-group-inet6" argument for the Cisco generator. This change allows policies to be generated that reference object groups for both ip and ip6 access lists.