Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] JSON AoS<->SoA redesign #1741

Open
LebedevRI opened this issue Jan 23, 2024 · 6 comments
Open

[FR] JSON AoS<->SoA redesign #1741

LebedevRI opened this issue Jan 23, 2024 · 6 comments

Comments

@LebedevRI
Copy link
Collaborator

Currently, we emit each repetition separately into JSON (and all at once apparently).
This is quite bloaty.

If we ever want to support iteration-as-repetition thing (and i think we do),
and perhaps if we want to AoS<->SoA our internal structs (and i think we do, especially if we do iteration-as-repetition),
i think we need to change the JSON schema.
The numberic fields (times, counters) need to become arrays of integers.

The tools/ will support both schemes, but external tooling will need similar updates.
I don't think we'd want to support two different json formats?

@dmah42 thoughts?

@dmah42
Copy link
Member

dmah42 commented Jan 23, 2024

bold!

I agree that the current json is the most naive approach, but before changing it I'd like to understand if it's currently hard for tooling to work with it. I suspect SoA would be easier even without iterations-as-repetitions, but I'd like to be sure.

I also agree, one format not two. it's hard enough to lose CSV!

if we do change it I think that's a major version bump, no?

@LebedevRI
Copy link
Collaborator Author

Roundtripping between the two would be trivial for JSON tools,
but yes, i suppose that would require a major version bump.
I'll first look into tools/, that will make it more apparent.

@LebedevRI
Copy link
Collaborator Author

LebedevRI commented Jan 23, 2024

Actually, version bump won't exactly help, we don't store version into JSON. It's a classic fatal error...

@dmah42
Copy link
Member

dmah42 commented Jan 23, 2024

oof. maybe we should start doing that first... is that a version bump? :)

@LebedevRI
Copy link
Collaborator Author

Do we believe that it would it be sufficient just to make it possible
to differentiate the version in JSON, by adding it as a field?

@dmah42
Copy link
Member

dmah42 commented Jan 23, 2024

i think so.. at least then readers have a chance to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants