Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform dataset coordinates into specified crs #97
transform dataset coordinates into specified crs #97
Changes from 1 commit
f1b63cf
d698f43
410104a
e260659
c6d574d
00ba444
b224db7
81766cf
24ff582
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @boothmanrylan we figured out that the issue is with
pixelLonLat()
actually as it gives the coordinates always into thedegree
so instead of that if you can use thislnglat_img = ee.Image.pixelCoordinates(ee.Projection(self.crs_arg))
then it gives the coordinates intogiven crs
format.Also change the bandIds from
longitude
tox
into at line 558.-> Same with
latitude
toy
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple import suggestions:
os
has already been imported. Please remove.tempfile
is a built-in Python module. Please move it up belowpathlib
.rioxarray
is unused. Please remove.rasterio
is not defined as a test dependency. Please include it inproject.optional-dependencies
tests
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do for
os
tempfile
andrasterio
However, from the rioxarray docs:
so without that import,
ds.rio.to_raster(...)
etc. fail with:AttributeError: 'Dataset' object has no attribute 'rio'
I can add rioxarray as a test dependency along with rasterio though.