Update xee dataflow example #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_655683820
branch
3 times, most recently
from
03170f2 to
8b3b1c1
Compare
This updates the xee dataflow example to prevent users from accidentally deleting storage bucket when running the example. This is a really simple fix for a bug in a recent [push to gcsfs](fsspec/gcsfs#608) paired with some [logic in the zarr library for writing datasets](https://github.com/zarr-developers/zarr-python/blob/df4c25f70c8a1e2b43214d7f26e80d34df502e7e/src/zarr/v2/storage.py#L567) which allows users to accidentally remove their bucket if writing to the root of a cloud storage bucket. This is problematic because users may have other data in a cloud storage bucket they may try to write to and accidental deletion of the bucket removes everything. Changes in this PR include: 1. pinning the `gcsfs` version to `<=2024.2.0` before the PR that introduced the bug 2. point to write to subdirectory on the bucket in the example PiperOrigin-RevId: 656046609
copybara-service
bot
force-pushed
the
test_655683820
branch
from
8b3b1c1 to
2c92e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update xee dataflow example
This updates the xee dataflow example to prevent users from accidentally deleting storage bucket when running the example.
This is a really simple fix for a bug in a recent push to gcsfs paired with some logic in the zarr library for writing datasets which allows users to accidentally remove their bucket if writing to the root of a cloud storage bucket. This is problematic because users may have other data in a cloud storage bucket they may try to write to and accidental deletion of the bucket removes everything.
Changes in this PR include:
gcsfsversion to<=2024.2.0before the PR that introduced the bug