Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot pin specific version of xee in my conda recipe #161

Open
12rambau opened this issue May 24, 2024 · 0 comments · May be fixed by #162
Open

Cannot pin specific version of xee in my conda recipe #161

12rambau opened this issue May 24, 2024 · 0 comments · May be fixed by #162
Labels
bug Something isn't working P1

Comments

@12rambau
Copy link
Contributor

xee is a dependency of geetools. I recently started to pin its version to a lower bound to provide full access to some new features.
Everything works fine in the pip release but I cannot manage to make the conda release to work.

If you look at this build (conda-forge/geetools-feedstock#6) it fails because the installed package METDATA are pointing to version 0.0.0 even though it's the 0.0.14 that get installed.

The conda teams (pinged in the linked PR) told me the recipe is correctly set up and the problem is coming from the xee conda release itself. Can you have a look and maybe make a patch release with the correct metadata ?
12rambau added a commit to 12rambau/Xee that referenced this issue May 24, 2024
@12rambau
set the version number somewhere
d8b3965 
Fix google#161 

My understanding of the problem is that the version number is not set anywhere. 

pyproject.toml uses a dynamic version number but the dynamic estination is not set, xee package has no __version__ variable. the one in `ext` is using the one from metadata which relies on the pyproject file. 

I decided to start this PR by setting where the dynamic version number should come from. Now I need your review to know where  the hard coded version number should be set.
@12rambau 12rambau linked a pull request May 24, 2024 that will close this issue
Open
@naschmitz naschmitz added bug Something isn't working P1 labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set the version number somewhere 12rambau/Xee
2 participants
@12rambau @naschmitz