Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep error domain com.google.GIDSignIn across the whole library. #425

Open
brnnmrls opened this issue May 20, 2024 · 0 comments
Open

Keep error domain com.google.GIDSignIn across the whole library. #425

brnnmrls opened this issue May 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@brnnmrls
Copy link
Member

brnnmrls commented May 20, 2024

At the moment, we have two error domains in the GSI (com.google.GIDSignIn and com.google.GIDVerify). Keeping the existing domain (com.google.GIDSignIn) will be the domain for all errors from this library while specific error codes will define the error. Though, the issue is avoiding collision across errors since error codes are solely integer backed enum cases and there's a chance integers are backed by the same one. We will revisit this to determine whether we should have two error domains or simplify to one.

Comment issue was brought up: https://github.com/google/GoogleSignIn-iOS/pull/414/files#r1599105257

@brnnmrls brnnmrls added the enhancement New feature or request label May 20, 2024
@brnnmrls brnnmrls self-assigned this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant