Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch when Souffle "helpfully" continues with malformed input in tests. #657

Open
markww opened this issue Aug 16, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@markww
Copy link
Contributor

markww commented Aug 16, 2022

Souffle, in its attempt to be helpful, tries to keep going when it sees slightly malformed input. This is not what we want for tests, as it could causes spurious passing results (example issue with malformed input error message: #655 ). To fix this, we should augment our test recipes to catch malformed inputs. This could happen, for instance, by redirecting the error output of Souffle to a file and greping that file for the malformed error message output.

@Cypher1 Cypher1 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants