Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in from_transformation in box.py #59

Open
melecmat opened this issue Feb 28, 2022 · 2 comments
Open

Possible bug in from_transformation in box.py #59

melecmat opened this issue Feb 28, 2022 · 2 comments

Comments

@melecmat
Copy link

Hi, I noticed that in the class method from_transformation in box.py, the transformation itself is thrown away, only the points are kept, upon calling cls(vertices=vertices). That cannot be right? For example, in IOU computation, the boxes are transformed by these transforms, so when they are not set it leads to different results.

Best,
Matous

@ahmadyan
Copy link
Collaborator

it is working as intended. It will keep the vertices, and sets everything else to None in the constructor. Every time if you access any of the transformation, rotation, translation, etc. if it is None it will fit a transformation to the vertices via [.fit()]( def translation(self):).

@melecmat
Copy link
Author

melecmat commented Mar 1, 2022

Ah, OK, now I see it. Thanks.

Out of curiosity, can I ask what is the main reason for this design choice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants