Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Triplet Marginal Loss #1118

Open
cvnad1 opened this issue Oct 23, 2024 · 2 comments
Open

[Feature] Triplet Marginal Loss #1118

cvnad1 opened this issue Oct 23, 2024 · 2 comments

Comments

@cvnad1
Copy link

cvnad1 commented Oct 23, 2024

I would like to add the Triplet Marginal Loss Function.

Reference: https://pytorch.org/docs/stable/_modules/torch/nn/functional.html#triplet_margin_loss

@vroulet
Copy link
Collaborator

vroulet commented Oct 23, 2024

Hello @cvnad1,

Feel free to proceed and add it to the self_supervised folder of the losses, so here

@cvnad1
Copy link
Author

cvnad1 commented Oct 26, 2024

@vroulet Hey sorry for a little delay

I completed the code for the loss function and am currently adding tests. Once the tests are added, I will create a PR.

Thanks for giving me the location where to add !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants