Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to building a JAR #69

Open
Fancy2209 opened this issue Dec 24, 2023 · 2 comments
Open

Revert to building a JAR #69

Fancy2209 opened this issue Dec 24, 2023 · 2 comments

Comments

@Fancy2209
Copy link

The way we are bundling it is both cursed and unreliable, it's preventing our Actions builds from working too, so this should be looked at at some point.

@meh2481
Copy link
Member

meh2481 commented Dec 24, 2023

I spent some time this morning fixing the actions builds (it wasn't packaging the whole thing). I actually like the current output instead of building a JAR; I couldn't ever get JavaFX to package into a JAR properly, and the current method bundles a whole Java JRE so nobody has to install everything else.

If anyone wants to make it build a JAR, they can feel free to do so and I won't complain, but at the very least our builds should be working fine now.

@Fancy2209
Copy link
Author

I mean if we get a jar, we can use launch4j and package one executable instead of the whole python folder, like Gootool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants