Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDF5 version 1.10 support? #16

Open
ggggggggg opened this issue Apr 26, 2018 · 6 comments
Open

HDF5 version 1.10 support? #16

ggggggggg opened this issue Apr 26, 2018 · 6 comments

Comments

@ggggggggg
Copy link

How likely is 1.10 support? What needs to be done to support 1.10?
@sbinet
Copy link
Member

sbinet commented Apr 26, 2018

What's new in 1.10? :)

@ggggggggg
Copy link
Author

I want to use the SWMR funtionality, see https://support.hdfgroup.org/HDF5/docNewFeatures/#1100

It only requires a few new functions. I tried pointing at an hdf5.h from 1.10.1_2 and all the tests seem to pass, so it seems like it works. I originally took the comment to mean it would totally fail on 1.10, but that doesn't seem to be the case.

As I understand to fully support SWMR one needs access to the functions: H5Dflush, H5DOappend, H5Drefresh and H5Fstart_swmr_write.

@sbinet
Copy link
Member

sbinet commented Apr 27, 2018

From a very quick look, it seems indeed possible.
There's one catch though: I am not sure how widespread 1.10 is so perhaps we should guard the new API behind a 'hdf5-1.10' build tag ?

PRs welcomed :)

@donkahlero
Copy link
Collaborator

donkahlero commented May 3, 2018 •
edited
Loading

Will also affect the H5PT interface. But the deprecated functions should still work in 1.10, so no big changes needed IMHO.

@donkahlero
Copy link
Collaborator

I think this library should not break, as I am running hdf5-dev in version 1.10 on my machine and it just works (I enabled deprecated support when I compiled). Then the calls could be gradually updated via PRs?
Guess it's just a matter of updating the travis config to use bionic instead of trusty :)

sbinet added a commit to sbinet-gonum/hdf5 that referenced this issue May 23, 2018
@sbinet
hdf5: first stab at hdf5-1.10 support
e5aab77 
This CL is a first step towards supporting new features and APIs
of HDF5 v1.10.

Right now, anecdotal evidence shows that HDF5 v1.8 is still massively
deployed so support for 1.10 has to be opt-in, by way of an optional
build tag aptly named "hdf5-v1.10"

Updates gonum#16.
sbinet added a commit to sbinet-gonum/hdf5 that referenced this issue May 23, 2018
@sbinet
hdf5: first stab at hdf5-1.10 support
070f812 
This CL is a first step towards supporting new features and APIs
of HDF5 v1.10.

Right now, anecdotal evidence shows that HDF5 v1.8 is still massively
deployed so support for 1.10 has to be opt-in, by way of an optional
build tag aptly named "hdf5-v1.10"

Updates gonum#16.
sbinet added a commit to sbinet-gonum/hdf5 that referenced this issue May 23, 2018
@sbinet
hdf5: first stab at hdf5-1.10 support
414f2c0 
This CL is a first step towards supporting new features and APIs
of HDF5 v1.10.

Right now, anecdotal evidence shows that HDF5 v1.8 is still massively
deployed so support for 1.10 has to be opt-in, by way of an optional
build tag aptly named "hdf5-v1.10"

Updates gonum#16.
sbinet added a commit to sbinet-gonum/hdf5 that referenced this issue May 23, 2018
@sbinet
hdf5: first stab at hdf5-1.10 support
f48c32f 
This CL is a first step towards supporting new features and APIs
of HDF5 v1.10.

Right now, anecdotal evidence shows that HDF5 v1.8 is still massively
deployed so support for 1.10 has to be opt-in, by way of an optional
build tag aptly named "hdf5-v1.10"

Updates gonum#16.
@sbinet sbinet mentioned this issue May 23, 2018
Open
@sbinet
Copy link
Member

sbinet commented May 23, 2018

I've started something at #21.

sbinet added a commit to sbinet-gonum/hdf5 that referenced this issue May 23, 2018
@sbinet
hdf5: first stab at hdf5-1.10 support
3b35669 
This CL is a first step towards supporting new features and APIs
of HDF5 v1.10.

Right now, anecdotal evidence shows that HDF5 v1.8 is still massively
deployed so support for 1.10 has to be opt-in, by way of an optional
build tag aptly named "hdf5_v1.10"

Updates gonum#16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbinet @donkahlero @ggggggggg