New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "amend allocation" endpoint #1244

Closed

maaktweluit opened this issue Apr 19, 2021 · 1 comment

Labels

core-payment optional

Contributor

maaktweluit commented Apr 19, 2021

Why:

If the user allocated not enough funds for a big task they might realize that in the middle of the task and increase the allocated amount.
If the allocation was made too big the user might want to lower it so that funds are not blocked and can be user for other allocations at the same time.
If the task takes long the user might want to extend allocation timeout so that it doesn't get released in the middle of the task.

What:

Implement the missing "amendAllocation" endpoint so that modifying the allocated amount and timeout is possible.
It shouldn't be possible to set the timeout so that the allocation is already timed-out.
It shouldn't be possible to lower the allocated amount so that it's lower than the amount already spent.
Take into account the transaction costs as well.
Add goth test.

maaktweluit added the core-payment label

maaktweluit added beta.2 optional labels

jiivan added beta.3 and removed beta.2 labels

nieznanysprawiciel removed the beta.3 label

prekucki closed this as completed

Member

prekucki commented Jan 18, 2024

github-project-automation bot added this to .Core

github-project-automation bot moved this to Done in .Core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment