New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker connect + worker update emits replayed stdout #694

Closed

vigoo opened this issue Jul 25, 2024 · 1 comment

Assignees

Labels

bug worker-executor

Milestone

Golem Open Source...

Contributor

vigoo commented Jul 25, 2024

Probably in general we are emitting stdout during recovery now
(Maybe a leftover debug change)

vigoo added bug worker-executor labels

vigoo added this to the Golem Open Source 1.0 milestone

vigoo self-assigned this

Contributor Author

vigoo commented Aug 9, 2024

This was a false report, I believe what happened was the following:

writing to stdout/err is currently not persisted to the oplog
but whether it is broadcasted to the connected clients or not depends on whether the worker is in replay mode
in the reported situation a worker update interrupted the execution, and during recovery it continued from the last persisted side effect, re-emitting some of these prints

vigoo closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment