Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose worker undo as a host function #1182

Open
vigoo opened this issue Dec 13, 2024 · 0 comments
Open

Expose worker undo as a host function #1182

vigoo opened this issue Dec 13, 2024 · 0 comments
Assignees
Milestone

Comments

@vigoo
Copy link
Contributor

vigoo commented Dec 13, 2024

The final step of the worker undo feature after #1180 and #1181 is to expose the same functionality for Golem workers via a new Golem-specific host function.

Steps:

  • Define the new API in golem:api/[email protected] in golem-wit
  • Implement it in worker executor by using the WorkerProxy to direct the request back through worker service (this is necessary because the target worker may not live in the same executor).
  • Optionally this can be optimized to directly call undo if the worker is local (like in the RPC implementation)
  • The implementation must be durable (write to the oplog) so the undo is not performed again during replay. See for example how "hot update" is exposed to workers, which is very similar.
  • Create a worker exeuctor test where a worker is undoing another worker through the host function
@vigoo vigoo added this to the Golem 1.2 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants