Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Gateway: Clean up Tasks #1170

Open
4 tasks
afsalthaj opened this issue Dec 10, 2024 · 0 comments
Open
4 tasks

API Gateway: Clean up Tasks #1170

afsalthaj opened this issue Dec 10, 2024 · 0 comments
Assignees
Milestone

Comments

@afsalthaj
Copy link
Contributor

afsalthaj commented Dec 10, 2024

  • Make sure we don't have concerning clones in the hot path of a custom http api requests. Please look through the workflow and see if there is any.
  • Remove type parameterized ApiDefinition, as the code is pretty much handling only Http now. The early type parameterisation did work out well, however, it was hard for a new contributor to see through these and easily gets into a state of "mixed" approach where, some parts are tightly coupled to Http. Let's be consistent instead of keeping a code that may become reasonable only in future. This is actually a minor change and doesn't sound as complicated.
  • Lookup logic for API definition shouldn't rely on Postgres. I think the cache was removed when moving from redis to Postgres. While fixing this point, it's a good idea to see how this is missed out.
  • Cors middleware is overly geared to browser's preflight requests. Origin handling should be done at the middleware but currently I see only the out middleware for CORS to add CORS headers, and not 1 for incoming requests (which I think, missed out when lifting and shifting of code and definitely points to absence of a particular test) - A pattern match process_in_middleware for cors is a Noop, which is wrong
@afsalthaj afsalthaj self-assigned this Dec 10, 2024
@afsalthaj afsalthaj changed the title Worker Gateway: Clean up Tasks API Gateway: Clean up Tasks Dec 10, 2024
@afsalthaj afsalthaj added this to the Golem 1.2 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant