Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security concern for golem-cli init #1

Open
gmlewis opened this issue Aug 27, 2024 · 1 comment
Open

Security concern for golem-cli init #1

gmlewis opened this issue Aug 27, 2024 · 1 comment

Comments

@gmlewis
Copy link

gmlewis commented Aug 27, 2024

When I run golem-cli init, then choose the "Golem Cloud" option and follow the instructions, I'm shown this warning from GitHub (with the IP address blocked out):

golem-warning-2024-08-27_09-07-29

I'm seriously concerned that the golem-cli command-line tool might be suffering from a man-in-the-middle attack where I'm giving my GitHub account access to an unknown third party (specifically, "Ashburn" at IP address 22.x.x.x as shown in the screenshot)... and I would really appreciate it if an official Golem team member could comment as to who/what this "Ashburn" is.

@noise64
Copy link

noise64 commented Aug 30, 2024

Thank you for the report!

Currently we are using the Github OAuth "Device flow" for accessing email in a reliable way, and this flow got moved to the backend, to make it more secure for us, and this resulted in seeing our AWS Cloud service asking for auth (Ashburn is an AWS datacenter).

We understand that this can generate security concerns, and not the right flow for this use case, and we started implementing the "Web application flow", which will happen inside the browser, but this will take time, and probably we can deploy it only in the next weeks.

Until then a few more details:

  • we only ask permission for getting email
  • after this one time email access we do not store or use this authorization anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@noise64 @gmlewis and others