Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #129

Closed
gaspaonrocks opened this issue Jan 24, 2018 · 56 comments
Closed

French translation #129

gaspaonrocks opened this issue Jan 24, 2018 · 56 comments
Assignees

Comments

@gaspaonrocks
Copy link

gaspaonrocks commented Jan 24, 2018

If you want i can help with french translation...

@goldbergyoni
Copy link
Owner

@gaspaonrocks sounds amazing, would you like to lead this work and find together others that will help you?

p.s. your name will be added to the core contributors + will be on top of the French page

@gaspaonrocks
Copy link
Author

@i0natan I'll start a readme.french.md then and wait for your instruction for the pull request.

@goldbergyoni
Copy link
Owner

@gaspaonrocks - French translation can be officially kicked-off. You're the lead! I'll be at your disposal should you need anything. Please create a branch for this work and PR to master once it's 100% done.

I would ask/recommend only 2 important guidelines:

Keep the same content & formatting - the focus is on translation, should anyone want to modify the content or the graphics - let's PR first in English and them translate to French
Duplicate pages - the content should be translated over a page duplication. Readme.MD became Readme.french.MD, all other files should be duplicated similarly. So the number of English & French pages should be the same. Will create a bold link from the English home page to the French home page (with bold credit of course...).

@adaube
Copy link

adaube commented Feb 13, 2018

I would love to be able to help on this PR. I see that @gaspaonrocks has the lead.

How can I help?

@gaspaonrocks
Copy link
Author

@adaube If you want we can split the work. Each of us having his pages to translate.

I started with the main page but I didn't realise it was massive. Maybe start with the smaller sections ?

@adaube
Copy link

adaube commented Feb 14, 2018

@gaspaonrocks that sounds great. Your approach of breaking the work down into smaller chunks is exactly how I like to roll! I'll fork and dive deeper this weekend, or sooner if I can carve out time.

@goldbergyoni
Copy link
Owner

sounds great. You may share in some French groups (FB, etc) to see whether other would like to join

@Annouar
Copy link

Annouar commented Mar 5, 2018

Hey !
If you guys need some help with French translation, let me know

@gaspaonrocks
Copy link
Author

@Annouar
Hey ! Sure, you can translate any parts. Any help is appreciated.

I have almost done the /sections/projectstructure folder, but i see that thincomponents.md and breakintocomponents.md is the exact same file. Any idea why @i0natan ?

I fixed some minor typos in the english files as well.

I'll PR once I'm done with this folder.

@goldbergyoni
Copy link
Owner

@gaspaonrocks @adaube @Annouar sounds great, really anxious to see it live

@Yaty
Copy link

Yaty commented Sep 2, 2018

Hey ! I'll be happy to contribute for the french translation :) What is not currently being translated ?

@goldbergyoni
Copy link
Owner

@Yaty Bienvenue.

Tagging @gaspaonrocks @adaube @Annouar

@NTurchi
Copy link

NTurchi commented Dec 11, 2018

Hi! I have seen that the French translation isn't done yet. I could work on it if you need some help.

@goldbergyoni goldbergyoni self-assigned this Dec 13, 2018
@goldbergyoni
Copy link
Owner

@NTurchi Bienvenue! 👍

@gaspaonrocks @adaube @Annouar I'd be glad to hear your thoughts (see @NTurchi message) and progress so far?

@goldbergyoni
Copy link
Owner

/remind me in 5 days

@reminders reminders bot added the reminder label Dec 15, 2018
@reminders
Copy link

reminders bot commented Dec 15, 2018

@i0natan set a reminder for Dec 20th 2018

@gaspaonrocks
Copy link
Author

gaspaonrocks commented Dec 17, 2018

Hello everyone,

Sorry for the lack of news about the french translation, but I have been swamped with work, which is a good thing. For everyone working on the French translation, you can do small files, and submit a PR for a review.

You announce what files you are working on before submitting the PR, that way duplicate work will be avoided.

I'll try and be more available.

Again, sorry and thanks to everyone involved.

@NTurchi
Copy link

NTurchi commented Dec 19, 2018

@gaspaonrocks If nobody work on it, I can translate "2.1 Use Async-Await or promises for async error handling" and also the attached article below "Read More: avoiding callbacks"

@reminders reminders bot removed the reminder label Dec 20, 2018
@reminders
Copy link

reminders bot commented Dec 20, 2018

👋 @i0natan,

@goldbergyoni
Copy link
Owner

@gaspaonrocks @NTurchi

Sounds great, as suggested let's start with small steps, do we need someone to correlate the work like maintain a list/table of what is translated by whom (avoiding duplicates)?

@gaspaonrocks
Copy link
Author

Yes ! I'll try and come up with a table with pages, the translator, and the status.

@Berkmann18
Copy link
Contributor

How's that going?
I'm fluent in French so thought I could help.

@pascaloliv
Copy link

I can give my help to review or contribute. 👍

@stale
Copy link

stale bot commented Apr 2, 2019

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Apr 2, 2019
@Berkmann18
Copy link
Contributor

@gaspaonrocks Any progress on that?

@forresst
Copy link
Contributor

Hi
I'd be happy to contribute :-) Just tell me how I can help 👷

@corentindesfarges First of all, thank you for your help. The simplest:

  1. Choose the file you want to translate from those that are not assigned in thise issue and leave me a comment in this issue so that I can assign you the translation of a file.
  2. Then fork my own fork and work on the french-translation branch
  3. When the work is done, propose a PR on my fork
  4. I will review your work

If you only want to review my work, you can post comments directly on my commits in Github

@goldbergyoni
Copy link
Owner

have a little daughter that keeps me busy 🤦‍♂

❤️

@stale
Copy link

stale bot commented Mar 15, 2020

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Mar 15, 2020
@forresst
Copy link
Contributor

This subject is still in progress, I'm behind schedule but the translation is progressing well. Moreover I received help for translation and proofreading. And that's great.

@stale stale bot removed the stale label Mar 16, 2020
@stale
Copy link

stale bot commented Jun 14, 2020

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Jun 14, 2020
@stale stale bot closed this as completed Jun 24, 2020
@goldbergyoni
Copy link
Owner

Hey @tkhadir ! Welcome 🎊, Thanks for approaching in #831 !

Let's continue the discussion here.

Dear @gaspaonrocks @samueldjones24 @corentindesfarges @forresst, Would you kindly help @tkhadir get on board and understand how to continue your wonderful work? Maybe can share with him some high-level status?

@goldbergyoni goldbergyoni reopened this Jan 1, 2021
@stale stale bot removed the stale label Jan 1, 2021
@tkhadir
Copy link
Contributor

tkhadir commented Jan 1, 2021

hello @goldbergyoni thanks for all :)

@forresst
Copy link
Contributor

forresst commented Jan 1, 2021

Sorry I've been away for more than 9 months, but I'm back to move on. I advise to follow the instructions of this comment

forresst pushed a commit to forresst/nodebestpractices that referenced this issue Jan 7, 2021
@forresst
Copy link
Contributor

Just to give you an update, 41 out of 87 files are translated and reviewed. Currently 10 are in progress or awaiting review.

I regularly update the translation according to the modifications applied to the original English version.

Anyone interested in translation and/or review is welcome.

@goldbergyoni
Copy link
Owner

@forresst Awesome progress. Is the homepage translated? If yes, shall we publish this already and then wait for the internal files?

cc @kevynb

@forresst
Copy link
Contributor

forresst commented Feb 2, 2021

@goldbergyoni @kevynb

The main page (README) is translated progressively. Currently, for the main page, parts 1, 2, 3 and 4 are translated and reviewed, part 5 is awaiting proofreading (Going To Production Practices). Part 6 is being translated (Security).

We have a main branch (french-translation) of all translations done and reviewed. An issue to follow the progress of the translations.

Two possibilities:

  • I can do a PR for the french-translation branch, this allows to have 47 out of 87 translated files and parts 1,2, 3 and 4 of the README.
  • I can focus on the translation of the main page, and provide the complete main page translation with all the other files already translated and reviewed.

What's your opinion?

@goldbergyoni
Copy link
Owner

Thank you @forresst

I like the 2nd option, focusing on the home page only for now. Let French readers read the main part at least, then gradually later process individual files. Maybe also @tkhadir and @corentindesfarges wish to be part of the home page writing.

@tkhadir
Copy link
Contributor

tkhadir commented Feb 3, 2021

Hello @forresst , @goldbergyoni

I will read this with pleasure this night :),

goldbergyoni pushed a commit that referenced this issue Feb 3, 2021
@forresst
Copy link
Contributor

forresst commented Feb 3, 2021

@goldbergyoni Ok, I focus on the translation of the main page

@tkhadir You can already review part 5 in priority

@goldbergyoni
Copy link
Owner

@forresst @tkhadir Awesome. Let me know how I can help.

@stale
Copy link

stale bot commented Jun 2, 2021

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Jun 2, 2021
@stale stale bot closed this as completed Jun 20, 2021
MatanYadaev pushed a commit to MatanYadaev/nodebestpractices that referenced this issue Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests