Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about messages which are not on the HYBRID API level #13

Open
stapelberg opened this issue Jan 21, 2025 · 0 comments
Open

Warn about messages which are not on the HYBRID API level #13

stapelberg opened this issue Jan 21, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@stapelberg
Copy link
Collaborator

(This is related to issue #10)

The open2opaque tool expects .proto files to be on the HYBRID API level so that the new accessor methods are already available, but the current code still builds (see https://protobuf.dev/reference/go/opaque-migration/#setup).

We should consider making the tool print a warning when it is invoked for proto messages which are not on the HYBRID API. Because open2opaque processes Go source code (not .proto files), we need to detect the API level based on the protogen struct tag in the Go message type.

@stapelberg stapelberg added the enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant