go/ast: SortImports does not change the (*ast.File).Imports field

[mateusz834]

Reproducer:

func TestSortImports(t *testing.T) {
	const src = `package test

import (
	"test"
	"test" // test comment
)
`

	fset := token.NewFileSet()
	f, err := parser.ParseFile(fset, "test.go", src, parser.ParseComments|parser.SkipObjectResolution)
	if err != nil {
		t.Fatal(err)
	}

	ast.SortImports(fset, f)

	importDeclSpecCount := len(f.Decls[0].(*ast.GenDecl).Specs)
	if importDeclSpecCount != 1 {
		t.Fatalf("len(f.Decls[0].(*ast.GenDecl).Specs) = %v; want = 1", importDeclSpecCount)
	}

	if len(f.Imports) != 1 {
		t.Fatalf("len(f.Imports) = %v; want = 1", len(f.Imports)) // fails with len(f.Imports) = 2; want = 1
	}
}

Currently ast.SortImports only updates the f.Decls[0].(*ast.GenDecl), the f.Imports field is untouched.

CC @griesemer

[gabyhelp]

Related Issues and Documentation

• Package ast > func SortImports ¶
• x/tools/cmd/goimports: bad sorting cannot be fixed completely #36140 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/616340 mentions this issue: go/ast: update (*File).Imports field in SortImports