You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(Although I think some issues are already resolved in latest spansql.)
Describe the solution you'd like
Migrating to another Spanner SQL parser implementation is a solution.
I recommend to consider cloudspannerecosystem/memefish.
Whose Spanner SQL coverage is already superset of spansql.
// The Spanner GCP backend does not yet support comments for the UpdateDatabaseDdl RPC
// (see https://issuetracker.google.com/issues/159730604) we use
// spansql to parse the DDL and output valid stamements without comments
ddl, err:=spansql.ParseDDL("", string(migration))
I think it can be implemented without full syntax parsing using only a lexer.
The text was updated successfully, but these errors were encountered:
apstndb
changed the title
Proposal: Migrate parser library in Spanner from spansql to memefish
Proposal: Migrate parser library in Spanner support from spansql to memefish
Nov 12, 2024
Is your feature request related to a problem? Please describe.
It seems that spansql package which is used in Spanner support is not actively developed.
googleapis/google-cloud-go#11115
Many of the issues opened due to spansql's lack of support for Spanner SQL syntax.
(Although I think some issues are already resolved in latest spansql.)
Describe the solution you'd like
Migrating to another Spanner SQL parser implementation is a solution.
I recommend to consider cloudspannerecosystem/memefish.
Whose Spanner SQL coverage is already superset of spansql.
Describe alternatives you've considered
Current usage of spansql is only splitting DDL statements and strip comments.
migrate/database/spanner/spanner.go
Lines 343 to 347 in c378583
I think it can be implemented without full syntax parsing using only a lexer.
The text was updated successfully, but these errors were encountered: