-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't add favicon #237
Comments
@kiyubits Can you share a screenshot of your browser network tab which shows the request for the favicon, it's path and http status code |
It looks like requesting any resource in your
@kiyubits After testing locally, I believe this is related to your baseURL = "https://kiyubits.github.io/kiyubytes/" Specifically,
When I set the following baseURL = "https://kiyubits.github.io/" |
So is the simple solution just changing the domain name to remove the sub directory Also, the
Also I'm not sure how to find the favicon in the browser network tab, how are favicons added using this theme? (I couldn't get a clear picture from the documentation) |
Yes.
I suspect this is related, and can be solved as above. |
Network tabOn Firefox, press F12 and go to the Network tab (Chromium browsers should be similar): FaviconsThe documentation is here: https://gokarna-hugo.netlify.app/posts/theme-documentation-basics/#favicons-browserconfig-manifest For example, my |
@kiyubits Do you want to try my solution? It'd be great to have another data point to base further investigation/documentation on. 🙂 |
Hey sorry I've been a little busy the past few days, but yeah I plan to recreate the whole repo but with the baseURL that you mentioned, and I'll see if that resolves the issues. If it does work then it would be nice if the documentation added a note that having a subdirectory as part of the baseURL might cause these kinds of issues :) |
Great! I noted here that similar issues have been lodged in this repo, so there may be a deeper cause which has gone unidentified; Hugo's own documentation defines a N.B. You can change your default branch (and re-write the Git history, if you wish), or change the |
As a workaround you can add something like: <link rel="icon" href="/blog/favicon.ico"> to |
The favicon 404 is one symptom of a misdeclared baseURL, other issues present themselves (such as navigation completely breaking on the local server) |
@kiyubits Howdy 🤠 have you made progress? |
hi i'm sooo sorry but i haven't worked on it at all since then, but i think i'm already pretty satisfied with the responses here so its okay if this issue is closed :) |
Hi i'm having issues with adding my own favicon
I've tried adding the favicon to the static folder
static/favicon.ico
but it isn't showingI tried looking at the example
config.toml
and it doesn't mention the favicon location, it leads me to believe that simply adding the favicon files in the static folder will make the favicon show after publishing (i think?), but that hasn't worked for meAdding my own images (like an avatar) worked though, with my
hugo.toml
file having(for some reason putting a "/" before images doesn't work for me), but the same thing with
favicon = ...
doesn't workmuch appreciated :D
The text was updated successfully, but these errors were encountered: