Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive Table of Contents #103

Open
jamesericdavidson opened this issue Jul 24, 2022 · 4 comments
Open

feat: responsive Table of Contents #103

jamesericdavidson opened this issue Jul 24, 2022 · 4 comments
Assignees

Comments

@jamesericdavidson
Copy link
Contributor

#95 added a Table of Contents for desktop, but it does not appear on mobile.

The Gokarna implementation is superior to the generic Hugo shortcode, so seeing this feature regardless of screen size would be great.

If you don't want to implement this feature yourselves, guidance on submitting a Pull Request would be appreciated! 😄

@yashmehrotra
Copy link
Collaborator

yashmehrotra commented Jul 27, 2022

@jamesericdavidson Thank you for the kind words.

We haven't implemented the mobile version yet cause its a bit tricky to create a nice UI which is both purposeful and aesthetic. We will probably implement it by adding a Table of contents dropdown at the start of the page

If you don't want to implement this feature yourselves, guidance on submitting a Pull Request would be appreciated!

That's highly appreciated, we'll try to pick this up and get this done next week but if that doesn't happen would love your help

@mansoorbarri
Copy link
Contributor

how about a colapse-able TOC with a button which is constantly displayed, something like this:
New Project

@yashmehrotra
Copy link
Collaborator

@mansoorbarri This does not match the UI design and looks bad

Have you seen any other sites doing this on mobile, curious to see how others have implemented it

@mansoorbarri
Copy link
Contributor

@mansoorbarri This does not match the UI design and looks bad

Have you seen any other sites doing this on mobile, curious to see how others have implemented it

https://christitus.com used to have a collapsible menu at the top of every article but now he has removed that too.

I think there is no "good" way to do this right now.

@jamesericdavidson jamesericdavidson changed the title Display a Table of Contents on mobile Feature Request: Responsive Table of Contents Oct 25, 2024
@jamesericdavidson jamesericdavidson changed the title Feature Request: Responsive Table of Contents feat: responsive Table of Contents Nov 1, 2024
jamesericdavidson added a commit to jamesericdavidson/jamesdavidson.xyz that referenced this issue Nov 4, 2024
Describe each project, and provide a link to it.

This will probably be removed if Gokarna gets a Table of Contents for
mobile:

gokarna-theme/gokarna-hugo#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants