Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying dynamic quality for lossy images through query parameter (q) #30

Open
albertusdev opened this issue Aug 26, 2019 · 2 comments
Open

Support specifying dynamic quality for lossy images through query parameter (q) #30

albertusdev opened this issue Aug 26, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@albertusdev
Copy link
Contributor

What would you like to be added

q query parameters support in Manipulator that enables dynamic quality based on query

Why is this needed

Currently all lossy images (JPEG & WebP) that is served by the same Processor will have the same quality, it would be nice to be able to specify q query parameter

Comments
@albertusdev albertusdev added enhancement New feature or request help wanted Extra attention is needed labels Aug 26, 2019
@baskarap
Copy link
Member

baskarap commented Sep 2, 2019

Is q the compression rate like what we have in internal darkroom at Gojek?

@albertusdev
Copy link
Contributor Author

@baskarap yes you are right, currently we support the q compression rate at Manipulator's constructor level, which results in constructing new Manipulator object for handling different q compression rate requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baskarap @albertusdev