Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow for Option #128

Open
1 task
brandonjpierce opened this issue Dec 10, 2024 · 2 comments
Open
1 task

Overflow for Option #128

brandonjpierce opened this issue Dec 10, 2024 · 2 comments

Comments

@brandonjpierce
Copy link
Contributor

Provide a general summary of the issue here

Screenshot 2024-12-10 at 2 35 49 PM

🤔 Expected Behavior?

A scrollbar would appear to allow users to view the remaining options

😢 Current Behavior

No overflow is applied so no scrollbar is present

🤩 Possible Solution

Just need to add overflow-y: auto to the option list

Participation

  • I am willing to submit a pull request for this change.

📜 Context

No response

🖥️ Steps to Reproduce

Generate a super long list of options in a height constrained viewport

Which package(s) are the source of the bug?

design-system

Version

0.4.0

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Wndows

@kalisjoshua
Copy link
Contributor

An option in the near future. https://youtu.be/MA9WAHEEfGM?si=E20wjIe-RiR0Oqk5

@brandonjpierce
Copy link
Contributor Author

Note for reviewers, you can fix this manually in the theme values for the time being:

{
  toggle: {
    options: {
      options: {
        container: style({
          overflowY: 'auto',
        }),
      },
    },
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants