-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeegoMaxMemoryBytes default set 128GB can be used to crash all Harbor instances. #21056
Comments
This value is a default provided by Harbor, suitable for various scenarios and hardware configurations. However, due to different user requirements and environments, it is recommended to customize the two values according to your specific scenarios and settings, rather than relying on the default. It is impractical to find a default value that satisfies everyone's needs, particularly considering security concerns, although 32GB and 128GB may not differ significantly in principle, reducing this value can still compromise the security of some machines with weaker configurations of machine. |
Especially in the current AI scenario, some users will package the model into an OCI artifact and store it in harbor, gather the new feature of k8s OCI volume, and mount the model as a volume in the workload. Due to the specificity of the model, many business models on the application side are often very large, dozens of gigabytes (G) or even hundreds of gigabytes (G). If the default value here is too small, it may cause the convenience of harbor in AI scenarios to be not so strong. |
I have a few observations about this setting and the conclusions we are silently assuming the Harbor users must comply with:
|
Expected behavior and actual behavior:
The PR #19578 increased Beego Max memory to 128 GiB allowing, so uploads up to 128 GiB will be stored in memory.
This can lead to instance crashes,
Steps to reproduce the problem:
Versions:
Please specify the versions of following systems.
harbor version: >2.10
Additional context:
https://github.com/beego/beedoc/blob/master/en-US/mvc/controller/params.md
The text was updated successfully, but these errors were encountered: