Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Performance Optimization: Using a Pool for Memory Allocation in Client Package #2897

Open
coderabbitai bot opened this issue Mar 4, 2024 · 1 comment
Labels
👍 Accepting PR hacktoberfest 🚀 Open for Hacktoberfest contributions! 🧹 Updates v3
Milestone

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2024

This issue tracks the exploration and potential implementation of a performance optimization mentioned in a pull request review comment. The optimization involves considering a pool for memory allocation to reduce the cost, specifically in the context of the function() within the file.

Potential Benefits

  • Reduced memory allocation and deallocation overhead.
  • Improved performance for high-throughput scenarios.

Context

Optimization Suggestions

  1. Reuse Client through Pool: Consider reusing the client through a pool, preferably the normal client or the underlying fasthttp client.

  2. Reuse Cookie Objects through Pool: Implement reusing cookie objects through a pool.

  3. Address Cookie Problems: Solve problems with cookies by removing the reference and replacing it with a copy.

Additional Input (Contributor's Suggestion)

The following suggestion is provided by a contributor and should be considered for integration:

  • Integrate the provided solution to address cookie problems by removing references and replacing them with copies.

Action Items

  1. Discuss the feasibility, potential impact, and implementation strategies for the suggested optimizations.
  2. Encourage contributors to share insights and propose designs.
  3. Initiate the exploration process for implementing the suggested optimizations.

Contributions and discussions are welcome to further refine and implement these optimizations for enhancing performance in the specified context.

Copy link

welcome bot commented Mar 4, 2024

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@ReneWerner87 ReneWerner87 added this to v3 Mar 6, 2024
@ReneWerner87 ReneWerner87 added this to the v3 milestone Mar 6, 2024
@gaby gaby moved this to Todo in v3 Mar 25, 2024
@gaby gaby added 👍 Accepting PR hacktoberfest 🚀 Open for Hacktoberfest contributions! labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Accepting PR hacktoberfest 🚀 Open for Hacktoberfest contributions! 🧹 Updates v3
Projects
Status: Todo
Development

No branches or pull requests

2 participants