Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 v3 Request: Refactor Client #1906

Closed
efectn opened this issue May 10, 2022 · 5 comments · Fixed by #1986
Closed

🚀 v3 Request: Refactor Client #1906

efectn opened this issue May 10, 2022 · 5 comments · Fixed by #1986
Assignees
Milestone

Comments

@efectn
Copy link
Member

efectn commented May 10, 2022

I think current client Implementation is very complex and limited. I think we should do these tasks to solve it:

  • Move client.go to client/. Project structure will be more tidy by splitting the client.
  • Re-create client by inspiring by go-resty/resty
@efectn efectn added this to the v3 milestone May 10, 2022
@balcieren
Copy link
Contributor

What do you think about node.js axios ? It's looking pretty for client.

@efectn
Copy link
Member Author

efectn commented May 11, 2022

What do you think about node.js axios ? It's looking pretty for client.

I don't have any experience with Node.js but it looks like nice. Guzzle is also good and clean client.

@efectn efectn added this to v3 Jun 5, 2022
@efectn efectn moved this to Todo in v3 Jun 5, 2022
@efectn efectn removed this from v3 Jun 5, 2022
@efectn efectn added this to v3 Jun 5, 2022
@efectn efectn moved this to Todo in v3 Jun 5, 2022
@YuilTripathee
Copy link
Contributor

Axios is a good one!

@wangjq4214
Copy link
Member

I think axios has good UX. And maybe I can work for this feature, which branch should I start my work?

@efectn
Copy link
Member Author

efectn commented Jul 27, 2022

I think axios has good UX. And maybe I can work for this feature, which branch should I start my work?

You can fork Fiber and work on v3-beta branch. I assign you to this issue.

@efectn efectn linked a pull request Jul 27, 2022 that will close this issue
27 tasks
@efectn efectn moved this from Todo to In Progress in v3 Jul 27, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in v3 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants