Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golist --provided should identify bundled code and generate the corresponding provides #7

Open
nim-nim opened this issue Mar 1, 2018 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@nim-nim
Copy link

nim-nim commented Mar 1, 2018

golist --provided should identify vendored/bundled code and generate the corresponding bundled() provides

@ingvagabund
Copy link
Contributor

ingvagabund commented Mar 2, 2018

INFO: the is applicable only to rpms that ship go binaries. It does not make sense to provide the bundled provides in devel only rpms. All the bundled provides should be collected in time the %gobuild macro is invoked (all imported packages must be reacheable from GOPATH/vendor). Each invocation generating a specific file. E.g.

%gobuild [opts] github.com/coreos/etcd/cmd/etcdctl

producing github.com.coreos.etcd.cmd.etcdctl.bundled file that gets read in the auto-generated provides.

@nim-nim
Copy link
Author

nim-nim commented Mar 2, 2018

No this is applicable to any shipped file whether it is built or not
If you ship vendored code in a devel package, with a legal problem, it needs to be identified with bundled()

(and actually you should change the package license to match all the licenses of the vendored code you install which is why shipping vendored code in devel packages is a terrible idea from a legal POW)

@ingvagabund
Copy link
Contributor

I am against shipping anything under vendor, Godeps, etc. Of course, we can not stop packages from doing that unless it violates the Fedora packaging guidelines. We can use the vendored deps to run tests, to build binaries. However, it does not make sense to use them as dependencies of a devel subpackage.

@nim-nim
Copy link
Author

nim-nim commented Mar 4, 2018

Anyway, this part is working again now in the shell code, no need to change golist for it (there will be a need to mark one way or another builds done with vendored code however)

@ingvagabund ingvagabund added the help wanted Extra attention is needed label Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants