Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why remove -git- from %{goname}? #53

Open
QuLogic opened this issue Jun 8, 2018 · 1 comment
Open

Why remove -git- from %{goname}? #53

QuLogic opened this issue Jun 8, 2018 · 1 comment

Comments

@QuLogic
Copy link

QuLogic commented Jun 8, 2018

I'm packaging go-netrc from git-lfs here and the new macros export %{goname} as golang-github-lfs-netrc. I understand that -go- is removed because it's all over the place in Go package names.

I don't understand why -git- is removed from %{goname} though. Looking at #3, none of them have a -git- in the name. Looking at the full list of Go packages (about double what's in #3), there are only 3 with -git- in the name. So it doesn't look like using -git- in the name is some big problem with Go packages that it needs to be stripped out.

@nim-nim
Copy link

nim-nim commented Jul 15, 2018

-git- was filtered because of
https://git.apache.org/

All Apache git urls start and end with git with zero functionnal meaning

The new filtering is more careful to only match such prefixes and suffixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants