Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 deposit history will display the withdrawal data of v0 #272

Open
Dawn-githup opened this issue Feb 16, 2023 · 1 comment
Open

V1 deposit history will display the withdrawal data of v0 #272

Dawn-githup opened this issue Feb 16, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request P-Medium

Comments

@Dawn-githup
Copy link

Dawn-githup commented Feb 16, 2023

####Steps to reproduce the behavior:
1.V0 initiates a withdrawal to v1
2.The transaction history will be displayed in both v0WithdrawalHistory and v1DepositHistory

####According to the light-godoken display rule, only one item needs to be displayed

This data is obtained from scan
getDepositHistories:

async getDepositHistories(page?: number): Promise<DepositResult[]> {
const ethAddress = this.provider.getL2Address();
const histories = await this.godwokenScannerClient.getDepositHistories(ethAddress, page);

getWithdrawalHistories

async getWithdrawalHistories(page?: number): Promise<WithdrawResultV0[]> {
const ownerLockHash = await this.provider.getLayer1LockScriptHash();
return await this.getWithdrawalHistoriesByOwnerLockHash(ownerLockHash, page);
}

@Dawn-githup Dawn-githup changed the title Deposit History will display the withdrawal records of v0 Deposit Histories will display the withdrawal records of v0 Feb 16, 2023
@Dawn-githup Dawn-githup changed the title Deposit Histories will display the withdrawal records of v0 DepositHistories will display the withdrawal records of v0 Feb 16, 2023
@Dawn-githup Dawn-githup changed the title DepositHistories will display the withdrawal records of v0 V1 deposit history will display the withdrawal data of v0 Feb 16, 2023
@Dawn-githup Dawn-githup added the enhancement New feature or request label Feb 16, 2023
@oriole-pub oriole-pub self-assigned this Feb 17, 2023
@Dawn-githup
Copy link
Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P-Medium
Projects
None yet
Development

No branches or pull requests

3 participants