Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALL: Make dependencies optional where possible #36

Open
jpaskhay opened this issue Jul 8, 2019 · 0 comments
Open

ALL: Make dependencies optional where possible #36

jpaskhay opened this issue Jul 8, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jpaskhay
Copy link
Contributor

jpaskhay commented Jul 8, 2019

All dependencies are currently required in existing language implementations (Java and C# as of this writing). For example, if someone uses the RDBMS metastore implementation, the SDK will still pull in the AWS DynamoDB SDK and all its transitive dependencies.

We can make pluggable external integrations and optional features only use optional dependencies so the user doesn't have to pull in dependency chains for unused parts.

An alternative approach we had discussed a while back was breaking out the external dependencies into separate projects/modules. The optional dependency approach seems like it will have less overhead in the SDK repo itself, and it shouldn't have much of a negative impact from an end user perspective.

Can discuss which approach seems best. Regardless of which approach is taken, we'll need to update documentation accordingly.
jpaskhay added a commit that referenced this issue Jul 8, 2019
@jpaskhay
checkpoint of optional dependency approach
68715f3 
- initial implementation of using optional dependencies for #36
- not ready for PR yet. we should verify this is the right approach. just wanted to push up local changes for reference
- reference apps and test app show the approach end users would need to pull in dependencies they'd want
- still need documentation changes
@sushantmimani sushantmimani mentioned this issue May 19, 2020
Closed
@nikoo28 nikoo28 added the enhancement New feature or request label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpaskhay @nikoo28